On Mon, 15 Jan 2018 at 12:15, Nithya Balachandran <nbalacha@xxxxxxxxxx> wrote:
Hi,A few questions about this:1. What (if anything) should be done for options like these which have "!" ?/* Switch xlator options (Distribute special case) */{ .key = "cluster.switch",.voltype = "cluster/distribute",.option = "!switch",.type = NO_DOC,.op_version = 3,.flags = VOLOPT_FLAG_CLIENT_OPT},
The options starting with bang doesn't get loaded with all the graphs and have special handling in glusterd-volgen code. I think we'd need these type of options handled specially in GD2's volgen as well, Aravinda? From the option perspective, I think we need to just copy the same option (with bang) in the respective xlators.
Kaushal/Aravinda - Please do confirm.
2. How should the changed key names handled?In glusterd:{ .key = "cluster.switch-pattern",.voltype = "cluster/switch",.option = "pattern.switch.case",.type = NO_DOC,.op_version = 3,.flags = VOLOPT_FLAG_CLIENT_OPT},In dht src code:/* switch option */{ .key = {"pattern.switch.case"},.type = GF_OPTION_TYPE_ANY,.op_version = {3},.flags = OPT_FLAG_CLIENT_OPT,},
We need to have both the patterns in the key as comma separated.
Regards,Nithya
_______________________________________________ Gluster-devel mailing list Gluster-devel@xxxxxxxxxxx http://lists.gluster.org/mailman/listinfo/gluster-devel
