Re: Message id's for components

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



This one is a good cleanup Xavi!

It is now merged!

On Wed, Dec 13, 2017 at 4:20 AM, Xavi Hernandez <jahernan@xxxxxxxxxx> wrote:
Hi,

I've uploaded a patch [1] to change the way used to reserve a range of messages to components and to define message id's inside a component.

The old method was error prone because adding a new component needed to define some macros based on previous macros (in fact there was already an invalid definition for a component). The definition of message id's for a component also required more than one modification and in some cases it was not correctly done.

The new patch defines the message constants using an enum, which automates all assignments, preventing most of the errors. It also defines a couple of macros that makes it even easier to create the component ranges and message id's.

Any feedback will be appreciated.

Regards,

Xavi


_______________________________________________
Gluster-devel mailing list
Gluster-devel@xxxxxxxxxxx
http://lists.gluster.org/mailman/listinfo/gluster-devel



--
Amar Tumballi (amarts)
_______________________________________________
Gluster-devel mailing list
Gluster-devel@xxxxxxxxxxx
http://lists.gluster.org/mailman/listinfo/gluster-devel

[Index of Archives]     [Gluster Users]     [Ceph Users]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux