Oops! Didn't noticed these changes were part of parent/child patches, Just noticed "BUILD BROKEN" and went into action :) I'm not sure about it! If it takes time to decide on whether the other set of patches need to be taken or not, at-least my patch will fix the broken build (That much I can assure) Lets see if the regressions break after these patch goes in (mostly not, that I see from the code) Thanks, -- Prasanna On Sat, Aug 27, 2016 at 8:34 PM, Atin Mukherjee <atin.mukherjee83@xxxxxxxxx> wrote: > > > On Saturday 27 August 2016, Prasanna Kalever <pkalever@xxxxxxxxxx> wrote: >> >> Here is the patch that should fix it >> http://review.gluster.org/#/c/15331/ > > > Thanks! Well thats an easy way, but the question here is dont we need the > parent patch to be merged to ensure there is no other functionality broken. > Currently I see that the parent patch has a -1, in that case is it required > to revert 15225? >> >> >> Happy weekend! >> >> -- >> Prasanna >> >> >> On Sat, Aug 27, 2016 at 7:49 PM, Atin Mukherjee <amukherj@xxxxxxxxxx> >> wrote: >> > [1] has broken mainline compilation and I feel this could be because its >> > parent patch is not been merged otherwise smoke should have caught it. >> > Please resolve it at earliest. >> > >> > [1] http://review.gluster.org/#/c/15225/ >> > >> > >> > --Atin >> > >> > _______________________________________________ >> > Gluster-devel mailing list >> > Gluster-devel@xxxxxxxxxxx >> > http://www.gluster.org/mailman/listinfo/gluster-devel >> _______________________________________________ >> Gluster-devel mailing list >> Gluster-devel@xxxxxxxxxxx >> http://www.gluster.org/mailman/listinfo/gluster-devel > > > > -- > --Atin _______________________________________________ Gluster-devel mailing list Gluster-devel@xxxxxxxxxxx http://www.gluster.org/mailman/listinfo/gluster-devel
