On Thu, Jun 30, 2016 at 1:57 PM, Niels de Vos <ndevos@xxxxxxxxxx> wrote: > On Thu, Jun 30, 2016 at 12:46:57PM +0530, Atin Mukherjee wrote: >> On Thu, Jun 30, 2016 at 11:56 AM, Atin Mukherjee <amukherj@xxxxxxxxxx> >> wrote: >> >> > >> > >> > On Thu, Jun 30, 2016 at 11:08 AM, Kaushal M <kshlmster@xxxxxxxxx> wrote: >> > >> >> Hi all, >> >> >> >> I'm (or was) planning to do a 3.7.13 release on schedule today. 3.7.12 >> >> has a huge issue with libgfapi, solved by [1]. >> >> I'm not sure if this fixes the other issues with libgfapi noticed by >> >> Lindsay on gluster-users. >> >> >> >> This patch has been included in the packages 3.7.12 built for CentOS, >> >> Fedora, Ubuntu, Debian and SUSE. I guess Lindsay is using one of these >> >> packages, so it might be that the issue seen is new. So I'd like to do >> >> a quick release once we have a fix. >> >> >> > >> > http://review.gluster.org/14835 probably is the one you are looking for. >> > >> > >> >> Ignore it. I had a chance to talk to Poornima and she mentioned that this >> is a different problem. > > The patch that fixes the problem is http://review.gluster.org/14822 and > I've merged it yesterday. The problem was introduced by > http://review.gluster.org/14822 (similar subject as 12835 above). This probably should be another review, the same change cannot possibly introduce and fix a problem. But are you sure that the VM pauses observed were due to buffer overflows, which the patch fixes? I think this is a different problem, as I'm pretty sure Lindsay was using packages that included this patch. > Unfortunately none of the libgfapi maintainer did completely review the > change before it got merged. It also seems that minimal testing was done > after the change got included (last minute change in 3.8, quickly > backported as well). > > In order to make Gluster more stable, and prevent problems like this > again, we really need to work on automating test cases. I hope all > maintainers are thinking about how they want to test the components they > are responsible for. For example, I'm planning to run the upstream QEMU > tests against our nightly builds (libgfapi), and similar for the > connectathon tests (Gluster/NFS). At one point it should be possible to > wrap these in DiSTAF, but the DiSTAF job in the CentOS CI is not ready > yet. > > Thanks, > Niels > > >> >> >> > >> >> Maintainers can merge changes into release-3.7 that follow the >> >> criteria given in [2]. Please make sure to add the bugs for patches >> >> you are merging are added as dependencies for the 3.7.13 tracker bug >> >> [3]. >> >> >> >> Thanks, >> >> Kaushal >> >> >> >> [1]: https://review.gluster.org/14822 >> >> [2]: https://public.pad.fsfe.org/p/glusterfs-release-process-201606 >> >> under the GlusterFS minor release heading >> >> [3]: https://bugzilla.redhat.com/show_bug.cgi?id=glusterfs-3.7.13 >> >> _______________________________________________ >> >> maintainers mailing list >> >> maintainers@xxxxxxxxxxx >> >> http://www.gluster.org/mailman/listinfo/maintainers >> >> >> > >> > > >> _______________________________________________ >> maintainers mailing list >> maintainers@xxxxxxxxxxx >> http://www.gluster.org/mailman/listinfo/maintainers > _______________________________________________ Gluster-devel mailing list Gluster-devel@xxxxxxxxxxx http://www.gluster.org/mailman/listinfo/gluster-devel
