Re: Issues from Gerrit Upgrade

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello folks,

As you may know, we upgraded to Gerrit on review.gluster.org to 2.12.2. After
this upgrade, several people noticed issues around logging into Gerrit.

In the past, some users had a username on Gerrit that is different from their
Github username. This worked fine until now. In the latest release, your
username should be the same as your Github username. People who face an issue
get a Server Error when they try to login to review.gluster.org.

There are two ways to go about fixing the server error.

# Option 1
We can delete the connection between your Github account and Gerrit.  When you
login again, a new user will be created for you with the username matching your
Github account.

Bad: You don't keep history of your old reviews on this new account.
Good: This is the least risky option.                                                                                                                                                                              

# Option 2
We change your Gerrit username to match your Github username.

Bad: There's a chance that things may break with the username change. Gerrit
doesn't allow you to change username because it's used in specific features.
Good: I can't find us using any of the features that may give us an issue, but
my search has not been thorough.
Good: You get to keep history.

# What we have done

From what I've gathered around conversations with people, we care about the
history. So I have changed everyone's Gerrit username to match their Github
username. Multiple people have tested and confirmed that this works.

Remember this means the username you use to push to Gerrit may have changed.
Please clear your cookies and cache and sign in to Gerrit and visit the account
page.

If you have any issues, please email me or ping me on IRC (I'm nigelb).

On Wed, Jun 1, 2016 at 4:07 PM, Nigel Babu <nigelb@xxxxxxxxxx> wrote:
Hello folks,

This upgrade has produced a side effect.

What Does Not Work:
Some people cannot login to Gerrit's web interface

What Does Work:
You can continue to push code and open review requests.

Problem:
If you have different github account and different gerrit username, you can't login to gerrit. For example, if your github username is nigelbabu and your gerrit username is nigelb, you can't login.

Affected:
People with a github account different from their gerrit username.

Solutions:
There are multiple solutions here and I'm yet to figure out which one I'll go with. In the meanwhile, I'd like a list of people affected, while I work out how to fix this. Please add your Gerrit username and Github username onto this etherpad if you're affected by this issue.
If your gerrit username is the same as your github username, you should be able to login without any issues. Please ignore the actions in this email.

Future Actions:
* We'll make it clear in the onboading process that having your github username same as your gerrit username is compulsory. By the way this plugin works, I think it will enforce it anyway.
* Better QA of a new version of Gerrit in staging before we upgrade. I skipped ahead with the upgrade a little too quickly. This would have otherwise been caught.


On Wed, Jun 1, 2016 at 3:30 PM, Atin Mukherjee <amukherj@xxxxxxxxxx> wrote:


On 06/01/2016 08:40 AM, Nigel Babu wrote:
> Hello folks,
>
> The upgrade is now complete! Please let me know if you notice anything
> wrong.

It does appear slow to me compared to previous version.

>
> On Wed, Jun 1, 2016 at 7:45 AM, Nigel Babu <nigelb@xxxxxxxxxx
> <mailto:nigelb@xxxxxxxxxx>> wrote:
>
>     Hello,
>
>     I'll be bring down Gerrit for upgrade to the latest version. I'll
>     update this thread when the upgrade is completed.
>
>     --
>     nigelb
>
>
>
>
> --
> nigelb
>
>
> _______________________________________________
> Gluster-devel mailing list
> Gluster-devel@xxxxxxxxxxx
> http://www.gluster.org/mailman/listinfo/gluster-devel
>



--
nigelb



--
nigelb
_______________________________________________
Gluster-devel mailing list
Gluster-devel@xxxxxxxxxxx
http://www.gluster.org/mailman/listinfo/gluster-devel

[Index of Archives]     [Gluster Users]     [Ceph Users]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux