Hi Kotresh, This is where I was peeping in http://review.nigelb.me/#/c/14346/1/xlators/features/index/src/index.c May be this patch could have been posted before upgrade ? Thanks, -- Prasanna On Tue, May 31, 2016 at 12:39 PM, Kotresh Hiremath Ravishankar <khiremat@xxxxxxxxxx> wrote: > Hi Prasanna, > > 'Fix' button is visible. May be you are missing something, please check. > > Thanks and Regards, > Kotresh H R > > ----- Original Message ----- >> From: "Prasanna Kalever" <pkalever@xxxxxxxxxx> >> To: "Nigel Babu" <nigelb@xxxxxxxxxx> >> Cc: "gluster-infra" <gluster-infra@xxxxxxxxxxx>, "gluster-devel" <gluster-devel@xxxxxxxxxxx> >> Sent: Tuesday, May 31, 2016 12:13:47 PM >> Subject: Re: [Gluster-infra] Please test Gerrit 2.12.2 >> >> Hi Nigel, >> >> I don't see 'Fix' button in the comment section which is "fix for a >> remote code execution exploit" introduced in 2.12.2, it helps us in >> editing the code in the gerrit web editor instantaneously, hence we >> don't have to cherry pick the patch every time to address minor code >> changes. >> >> I feel that is really helpful for the developers to address comments >> faster and easier. >> >> Please see [1], it also has attachments showing how this looks >> >> [1] http://www.gluster.org/pipermail/gluster-devel/2016-May/049429.html >> >> >> Thanks, >> -- >> Prasanna >> >> On Tue, May 31, 2016 at 10:39 AM, Nigel Babu <nigelb@xxxxxxxxxx> wrote: >> > Hello, >> > >> > A reminder: I'm hoping to get this done tomorrow morning at 0230 GMT[1]. >> > I'll have a backup ready in case something goes wrong. I've tested this >> > process on review.nigelb.me and it's gone reasonably smoothly. >> > >> > [1]: >> > http://www.timeanddate.com/worldclock/fixedtime.html?msg=Maintenance&iso=20160601T08&p1=176&ah=1 >> > >> > On Mon, May 30, 2016 at 7:26 PM, Nigel Babu <nigelb@xxxxxxxxxx> wrote: >> >> >> >> Hello, >> >> >> >> I've now upgraded Gerrit on http://review.nigelb.me to 2.12.2. Please >> >> spend a few minutes testing that everything works as you expect it to. If >> >> I >> >> don't hear anything negative by tomorrow, I'd like to schedule an upgrade >> >> this week. >> >> >> >> -- >> >> nigelb >> > >> > >> > >> > >> > -- >> > nigelb >> > >> > _______________________________________________ >> > Gluster-infra mailing list >> > Gluster-infra@xxxxxxxxxxx >> > http://www.gluster.org/mailman/listinfo/gluster-infra >> _______________________________________________ >> Gluster-devel mailing list >> Gluster-devel@xxxxxxxxxxx >> http://www.gluster.org/mailman/listinfo/gluster-devel >> _______________________________________________ Gluster-devel mailing list Gluster-devel@xxxxxxxxxxx http://www.gluster.org/mailman/listinfo/gluster-devel
