Hi Karthik, Would it be possible for you to backport Krutika's patch [1] to release-3.8? I am running tests with 3.8rc0 and am running into excessive logging problems addressed by the patch. Thanks, Vijay [1] http://review.gluster.org/#/c/14182/ On Wed, May 4, 2016 at 1:16 AM, Karthik Subrahmanya <ksubrahm@xxxxxxxxxx> wrote: > Thanks Krutika, Atin, Joseph for the inputs. I will send out a patch with this issue fixed. > > Regards, > Karthik > > ----- Original Message ----- >> From: "Joseph Fernandes" <josferna@xxxxxxxxxx> >> To: "Karthik Subrahmanya" <ksubrahm@xxxxxxxxxx>, "Krutika Dhananjay" <kdhananj@xxxxxxxxxx> >> Cc: "Gluster Devel" <gluster-devel@xxxxxxxxxxx>, "Atin Mukherjee" <amukherj@xxxxxxxxxx> >> Sent: Wednesday, May 4, 2016 6:21:23 AM >> Subject: Re: Worm translator not truly disabled by default? >> >> Well I completely agree with Krutika that doing a getxattr for every FOP is >> not required >> if the worm or worm-file option is off. >> >> Karthik, >> And you need to check if the worm or worm-file option is set, then only go >> ahead and do the checking. >> For now as the feature is experimental and the whole purpose is to provide >> the WORM/Retention semantic >> experience to user. >> Later when the feature matures, Once the volume is changed to "Enterprise >> WORM/Retention" Mode,there >> would be no going back. >> >> Could you please send out a patch for this asap ? >> >> Regards, >> Joe >> >> ----- Original Message ----- >> > From: "Atin Mukherjee" <amukherj@xxxxxxxxxx> >> > To: "Karthik Subrahmanya" <ksubrahm@xxxxxxxxxx>, "Krutika Dhananjay" >> > <kdhananj@xxxxxxxxxx> >> > Cc: "Gluster Devel" <gluster-devel@xxxxxxxxxxx> >> > Sent: Tuesday, May 3, 2016 6:22:55 PM >> > Subject: Re: Worm translator not truly disabled by default? >> > >> > >> > >> > On 05/03/2016 05:10 PM, Karthik Subrahmanya wrote: >> > > >> > > >> > > ----- Original Message ----- >> > >> From: "Krutika Dhananjay" <kdhananj@xxxxxxxxxx> >> > >> To: "Joseph Fernandes" <josferna@xxxxxxxxxx>, "Karthik Subrahmanya" >> > >> <ksubrahm@xxxxxxxxxx> >> > >> Cc: "Gluster Devel" <gluster-devel@xxxxxxxxxxx> >> > >> Sent: Tuesday, May 3, 2016 2:53:02 PM >> > >> Subject: Worm translator not truly disabled by default? >> > >> >> > >> Hi, >> > >> >> > >> I noticed while testing that worm was sending in fgetxattr() fops as >> > >> part >> > >> of a writev() request from the parent, despite being disabled by >> > >> default. >> > >> >> > > This is because of the new feature called "file level worm" which is >> > > introduced in the worm >> > > translator. This will allow to make individual files as worm/retained by >> > > setting the volume >> > > option "worm-file-level". The files which are created when this option is >> > > enabled will have >> > > an xattr called "trusted.worm_file". This is implemented because unlike >> > > read-only or volume >> > > level worm where if the option on the volume is disabled, the entire >> > > translator will get >> > > disabled and you can perform any FOP on the files in that volume. But >> > > here >> > > if a file is once >> > > marked as worm-retained, it should not revert back to the normal state >> > > where we can change >> > > its contents even if the worm-file-level option is reset/disabled. So the >> > > xattr is set on the >> > > file and every time when a write, link, unlink, rename, or truncate fop >> > > comes it checks for >> > > the xattr. >> > I am not sure with what test Krutika observed it, but if any worm >> > tunable is not set then ideally we shouldn't hit it. I believe you set >> > this xattr only when worm-file-level is turned on but that's also >> > disabled by default. Krutika, could you confirm it? >> > > Hope it helps. >> > > >> > > Thanks & Regards, >> > > Karthik >> > >> >> > >> I've sent a patch for this at http://review.gluster.org/#/c/14182/ >> > >> I must admit I do not understand the internals of this new translator. >> > >> >> > >> Request your feedback/review. >> > >> >> > >> -Krutika >> > >> >> > > _______________________________________________ >> > > Gluster-devel mailing list >> > > Gluster-devel@xxxxxxxxxxx >> > > http://www.gluster.org/mailman/listinfo/gluster-devel >> > > >> > _______________________________________________ >> > Gluster-devel mailing list >> > Gluster-devel@xxxxxxxxxxx >> > http://www.gluster.org/mailman/listinfo/gluster-devel >> > >> > _______________________________________________ > Gluster-devel mailing list > Gluster-devel@xxxxxxxxxxx > http://www.gluster.org/mailman/listinfo/gluster-devel _______________________________________________ Gluster-devel mailing list Gluster-devel@xxxxxxxxxxx http://www.gluster.org/mailman/listinfo/gluster-devel
