On Jul 2, 2015, at 8:35 PM, Jeff Darcy <jdarcy@xxxxxxxxxx> wrote: >> Or perhaps we could just get everyone to stop using 'inline' > > I agree that it would be a good thing to reduce/modify our use of > 'inline' significantly. Any advantage gained from avoiding normal > function-all entry/exit has to be weighed against cache pollution from > having the same code repeated over and over each place the function is > invoked. Careful use of 'extern inline' can be good for performance > and/or readability once in a great while, but IMO we should avoid > 'inline' except in cases where the benefits are *proven*. > > On a similar note, can we please please please get people to stop > abusing macros so much? I get that they're sometimes useful to get > around C's lack of generics or other features, but many of our long > complicated macros have no such justification. These pollute the cache > just like 'inline' does, plus they make code harder to debug or edit. And in the past, if not now, are contributing factors to small file performance issues. -peter > _______________________________________________ > Gluster-devel mailing list > Gluster-devel@xxxxxxxxxxx > http://www.gluster.org/mailman/listinfo/gluster-devel _______________________________________________ Gluster-devel mailing list Gluster-devel@xxxxxxxxxxx http://www.gluster.org/mailman/listinfo/gluster-devel
