On 15 Jun 2015 19:23, "Kaushal M" <kshlmster@xxxxxxxxx> wrote:
>
> > I like this idea. One tweak I'd make is to introduce the idea of
> > Verified+1 for smoke and Verified+2 for regressions. Why? Because it
> > seems like a lot of people won't even review a patch until they can
> > see that it has been sanity-checked. If we formally require review
> > before verification, and informally need verification before review,
> > we're stuck.
>
> I should have made this clearer in the steps I listed.
> Under the 2nd step (I should have numbered as well), I've mentioned
> that Zuul will report back the status of smoke/pre-review tests. This
> is the Verified+1. Though I was thinking of using different flags, we
> can use Verified it self to serve both pre and post review checks.
I would like to see two different flags, one for smoke and other for regression. Off late, we have seen cases where votes get overridden.
> _______________________________________________
> Gluster-devel mailing list
> Gluster-devel@xxxxxxxxxxx
> http://www.gluster.org/mailman/listinfo/gluster-devel
_______________________________________________ Gluster-devel mailing list Gluster-devel@xxxxxxxxxxx http://www.gluster.org/mailman/listinfo/gluster-devel
