Re: [PATCH] fix possible array out of bound

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



hi,
Welcome to glusterfs :-). Could you please follow the instructions here to send the patch.
http://www.gluster.org/community/documentation/index.php/Simplified_dev_workflow

Pranith.

On 08/12/2014 08:52 AM, Ruoyu wrote:
fix dangerous usage of volname because strncpy does not always
null-terminated.

Signed-off-by: Ruoyu <liangry@xxxxxxxxx>
---
  xlators/nfs/server/src/nfs-common.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/xlators/nfs/server/src/nfs-common.c b/xlators/nfs/server/src/nfs-common.c
index f74396e..1462c1b 100644
--- a/xlators/nfs/server/src/nfs-common.c
+++ b/xlators/nfs/server/src/nfs-common.c
@@ -85,7 +85,7 @@ nfs_mntpath_to_xlator (xlator_list_t *cl, char *path)
          if ((!cl) || (!path))
                  return NULL;
- strncpy (volname, path, MNTPATHLEN);
+        snprintf (volname, sizeof(volname), "%s", path);
          pathlen = strlen (volname);
          gf_log (GF_NFS, GF_LOG_TRACE, "Subvolume search: %s", path);
          if (volname[0] == '/')

_______________________________________________
Gluster-devel mailing list
Gluster-devel@xxxxxxxxxxx
http://supercolony.gluster.org/mailman/listinfo/gluster-devel




[Index of Archives]     [Gluster Users]     [Ceph Users]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux