Re: bug-822830.t fails on release-3.5 branch

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Thanks guys for looking into this. I am just wondering how this passed the regression before Niels could merged this in? Good part is test case needs modification not code ;)

-Santosh


On 07/04/2014 11:51 AM, Ravishankar N wrote:
On 07/04/2014 11:20 AM, Pranith Kumar Karampuri wrote:

On 07/04/2014 11:19 AM, Ravishankar N wrote:
On 07/04/2014 11:09 AM, Pranith Kumar Karampuri wrote:
Ravi,
I already sent a patch for it in the morning at http://review.gluster.com/8233
Review please :-)

830665.t is identical in master where it succeeds. Looks like *match_subnet_v4() changes in master need to be backported to 3.5 as well.
That is because Avati's patch where EXPECT matches reg-ex is not present on release-3.5

commit 9a34ea6a0a95154013676cabf8528b2679fb36c4
Author: Anand Avati <avati@xxxxxxxxxx>
Date:   Fri Jan 24 18:30:32 2014 -0800

    tests: support regex in EXPECT constructs

    Instead of just strings, provide the ability to specify a regex
    of the pattern to expect

    Change-Id: I6ada978197dceecc28490a2a40de73a04ab9abcd
    Signed-off-by: Anand Avati <avati@xxxxxxxxxx>
    Reviewed-on: http://review.gluster.org/6788
    Reviewed-by: Pranith Kumar Karampuri <pkarampu@xxxxxxxxxx>
    Tested-by: Gluster Build System <jenkins@xxxxxxxxxxxxxxxxx>

Shall we backport this?


I think we should; reviewed http://review.gluster.org/#/c/8235/. Thanks for the fix :)

Pranith
Pranith

On 07/04/2014 11:00 AM, Ravishankar N wrote:
Hi Niels/ Santosh,

tests/bugs/bug-830665.t is consistently failing on 3.5 branch:
not ok 17 Got "*.redhat.com" instead of "\*.redhat.com"
not ok 19 Got "192.168.10.[1-5]" instead of "192.168.10.\[1-5]"

and seems to be introduced by http://review.gluster.org/#/c/8223/

Could you please look into it?

Thanks,
Ravi




_______________________________________________
Gluster-devel mailing list
Gluster-devel@xxxxxxxxxxx
http://supercolony.gluster.org/mailman/listinfo/gluster-devel





_______________________________________________
Gluster-devel mailing list
Gluster-devel@xxxxxxxxxxx
http://supercolony.gluster.org/mailman/listinfo/gluster-devel




[Index of Archives]     [Gluster Users]     [Ceph Users]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux