Re: Change in glusterfs[master]: build: Support for unit tests using Cmockery2

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



I agree that this is a major issue. Justin and I for a while tried to build the regressions on different VMs (other than build.gluster.org). I was never successull in running the regression on either CentOS 6.5 or Fedora. Once we are able to run them on any VM, we can then parallelize (is that a word) the regression workload over many (N) VMs.

I like your stage-1 idea. In previous jobs we had a script called "presubmit.sh" which did all you have described there. I'm not sure if forcing developers is a good idea, though. I think that if we shape up Jenkins to do the right thing, with the stages implemented there (and run optionally by the developers -- I would like to run them before I submit), then this issue would be resolved.

- Luis

On 05/07/2014 03:27 PM, Harshavardhana wrote:
This has been really bothering me a bit as our queues are getting
bigger and bigger upstream to even get smallest of the patches to get
fixed quickly.

In these scenarios a decentralized regression testing could be made mandatory?

stage-1 tests - runs on the Author's laptop (i.e Linux) - git hook
perhaps which runs for each ./rfc.sh (reports build issues, other
apparent compilation problems, segfaults on init etc.)
     This could comprise of
     - smoke.sh
     - 'make -j16, make -j32' for parallel build test
     - Unittests

stage-2 tests - run on the initial review post.
     - build rpms EL5, EL6, FC20, future
     - mockbuild
     - ./tests/basic/*
     - any others?

stage-3 tests - run on the final Verification process.
     - full blown ./tests/bugs/*

Currently if you look at the regression test suite it getting bigger
and bigger (our overall time of regression test) completion. Just a
though since simple build failures, compilation failure and other
really simple bugs - upstream servers shouldn't be used. One can
leverage Author's laptop :-)

Don't know what you guys think?

On Wed, May 7, 2014 at 12:00 PM, Luis Pabon (Code Review)
<review@xxxxxxxxxxxxxxx> wrote:
Luis Pabon has posted comments on this change.

Change subject: build: Support for unit tests using Cmockery2
......................................................................


Patch Set 6:

Good point, but unit tests take no more time to compile, and only take 0.55 secs to run all of them (at the moment).  Is this really an issue?

--
To view, visit http://review.gluster.org/7538
To unsubscribe, visit http://review.gluster.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1b36cb1f56fd10916f9bf535e8ad080a3358289f
Gerrit-PatchSet: 6
Gerrit-Project: glusterfs
Gerrit-Branch: master
Gerrit-Owner: Luis Pabon <lpabon@xxxxxxxxxx>
Gerrit-Reviewer: Gluster Build System <jenkins@xxxxxxxxxxxxxxxxx>
Gerrit-Reviewer: Harshavardhana <harsha@xxxxxxxxxxxxxxxxxx>
Gerrit-Reviewer: Jeff Darcy <jdarcy@xxxxxxxxxx>
Gerrit-Reviewer: Justin Clift <justin@xxxxxxxxxxx>
Gerrit-Reviewer: Kaleb KEITHLEY <kkeithle@xxxxxxxxxx>
Gerrit-Reviewer: Luis Pabon <lpabon@xxxxxxxxxx>
Gerrit-Reviewer: Rajesh Joseph <rjoseph@xxxxxxxxxx>
Gerrit-Reviewer: Ravishankar N <ravishankar@xxxxxxxxxx>
Gerrit-Reviewer: Vijay Bellur <vbellur@xxxxxxxxxx>
Gerrit-HasComments: No



_______________________________________________
Gluster-devel mailing list
Gluster-devel@xxxxxxxxxxx
http://supercolony.gluster.org/mailman/listinfo/gluster-devel




[Index of Archives]     [Gluster Users]     [Ceph Users]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux