Re: [PATCH 2/2] pack-objects: report actual number of threads to be used

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, Apr 04, 2009 at 01:20:18PM -0500, Dan McGee wrote:

> > That makes sense to me, though I wonder if it may confuse and frustrate
> > users who are expecting their awesome quad-core machine to be using 4
> > threads when it only uses 2. Is it worth printing both values, or some
> > indicator that we could have been using more?
> 
> I thought of this, but decided it wasn't really worth it. The default
> window size of 10 makes it a very rare case that you will use fewer
> than 4 threads. With the default, each thread needs a minimum of 20
> objects, so even a 100-object repository would spawn the 4 threads.

Good point. Though by that logic, isn't your patch also not worth it
(i.e., it is unlikely not to fill the threads, so the output will be the
same with or without it)?

I still think yours is an improvement, though, however slight.

-Peff
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux