On Sat, Apr 04, 2009 at 11:59:56AM -0500, Dan McGee wrote: > In the case of a small repository, pack-objects is smart enough to not start > more threads than necessary. However, the output to the user always reports > the value of the pack.threads configuration and not the real number of > threads to be used. This is easily fixed by moving the printing of the > message after we have partitioned our work. > > (pack.threads is on autodetect and would be set to 4) > $ git-repack -a -d -f > Counting objects: 55, done. > Delta compression using 2 threads. > Compressing objects: 100% (48/48), done. > Writing objects: 100% (55/55), done. > Total 55 (delta 10), reused 0 (delta 0) That makes sense to me, though I wonder if it may confuse and frustrate users who are expecting their awesome quad-core machine to be using 4 threads when it only uses 2. Is it worth printing both values, or some indicator that we could have been using more? -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
