On Thu, Mar 19, 2009 at 12:56:37AM -0400, Jay Soffian wrote: > > As a side note, I find this solution a little bit ugly. String lists > > should sort on their strings, not on some other random magic in the util > > field. This usage really abuses string_list a bit as a data type because > > we have no generic "list" type. > > I really don't think so. The string_list API accommodates this case > quite nicely. So why not? I think the code would be more natural as a list of structs, each with a source and dest. But C does not make it pleasant to write generic data types, so things end up stuffed into string_lists with a magic util field. So I think leaving it as a string_list is probably the most sane thing to do. -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
