BTW, following patches are not available yet : P On Wed, Mar 18, 2009 at 5:52 PM, pi song <pi.songs@xxxxxxxxx> wrote: > Wait. If you look at the builtin-blame.c, out of question it is very > messy. Things like print_usage() or -L parameter parsing for example > is not done upfront but hiding somewhere. Some functions are not very > clear if they are frontend or backend. I would say nobody would be > able to split it right in the first place. What you could do is to > split it to something "roughly right" and then work from that. > > My latest two patches really do nothing but just splitting files. I > haven't changed any logics or renamed any thing only to make this big > beast more *manageable* rather than tackling the problem directly. > Yes, some bits are still wrong but I believe 70% of the functions > should already stay in the right place. The following patches will > make the structure more right *gradually*. > > Pi Song > > > On Wed, Mar 18, 2009 at 5:20 PM, Junio C Hamano <gitster@xxxxxxxxx> wrote: >> pi song <pi.songs@xxxxxxxxx> writes: >> >>> Don't you think we should rather split up into smaller files before >>> start reorganizing things? >> >> Yes, but splitting it wrong is, eh, wrong ;-) >> > -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
