Alexandre Julliard <julliard@xxxxxxxxxx> writes: > David Kågedal <davidk@xxxxxxxxxxxxxx> writes: > >> Signed-off-by: David Kågedal <davidk@xxxxxxxxxxxxxx> >> --- >> >> Here is a version that can to both commit name lookup and branch name >> lookup, and with a configuration parameter that determines how to find >> branch names to complete on. > > Why do you introduce a separate function for checkouts? I don't see > much need to have a different set of completions for checkout > vs. cherry-pick, they both can be used with an arbitrary commit anyway. Yes, but the typical uses differ a lot. The (overwhelmingly) typical use of checkout is to switch to another branch. The typical use of cherry-pick is to pick any commit and not treat branch heads specially. So when switching branches, I obviously want a simple way to select which branch to switch to. When cherry-picking, I would need some simple way of picking any single commit, but that's hard so making it easy to pick any named commit is probably the reasonable solution. -- David Kågedal -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
