On Thu, Feb 19, 2009 at 07:36:49AM +0000, John Tapsell wrote:
> All the error messages starting "Error: " begin with a captial E, except
> in one place. This commit fixes this, making the output look more
> consistent. At the moment a failed push, say, looks like:
>
> Error: cannot lock existing info/refs
> error: failed to push some refs to 'some repository'
I think this commit message is a little misleading. True, there is only
one place where "error:" appears, but it is the place that is called by
almost every piece of code. So by far the majority of errors are "error:
".
http-push seems to be the odd man out. It contains one fprintf(stderr,
"Error: ...") and one totally bogus error("Error: ..."), which will
print "error: Error: ...". Perhaps it would be better to scan through
the code and switch to using error() and warning() as appropriate.
That will make things consistent, which addresses your complaint. And
then there can be a discussion if people want about whether "Error:" or
"error:" is better (personally I like lowercase).
-Peff
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
