John Tapsell wrote:
> All the error messages starting "Error: " begin with a captial E, except
> in one place. This commit fixes this, making the output look more
> consistent. At the moment a failed push, say, looks like:
>
> Error: cannot lock existing info/refs
> error: failed to push some refs to 'some repository'
[...]
> - report("fatal: ", err, params);
> + report("Fatal: ", err, params);
A quick grep says this is going to break the tests:
t/t1400-update-ref.sh: test "warning: Log for '\'master\'' only goes back to $ed." = "$(cat e)"'
t/t1400-update-ref.sh: echo test "warning: Log for '\'master\'' only goes back to $ed." = "$(cat e)"'
t/t1400-update-ref.sh: test "warning: Log for '\''master'\'' only goes back to $ed." = "$(cat e)"'
t/t1400-update-ref.sh: test "warning: Log .git/logs/'"$m has gap after $gd"'." = "$(cat e)"'
t/t1400-update-ref.sh: test "warning: Log .git/logs/'"$m unexpectedly ended on $ld"'." = "$(cat e)"'
t/t4012-diff-binary.sh: detected=`expr "$detected" : "fatal.*at line \\([0-9]*\\)\$"` &&
t/t4012-diff-binary.sh: detected=`expr "$detected" : "fatal.*at line \\([0-9]*\\)\$"` &&
t/t4018-diff-funcname.sh: grep "fatal" > /dev/null )
t/t4018-diff-funcname.sh: grep "fatal: Last expression must not be negated:"
t/t5400-send-pack.sh: grep "warning: to refuse deleting" child/errs &&
t/t5510-fetch.sh: grep "fatal: '\''a\\\\!'\''b'\''" result
t/t5516-fetch-push.sh: grep "warning: updating the current branch" stderr
t/t5516-fetch-push.sh: ! grep "warning: updating the current branch" stderr
t/t5516-fetch-push.sh: ! grep "warning: updating the current branch" stderr
t/t6300-for-each-ref.sh: \"error: more than one quoting style\"*) : happy;;
t/test-lib.sh: say_color error "error: $*"
That being said, I'm not sure we can change this at all since it's the
plumbing way of reporting errors/warnings.
--
Thomas Rast
trast@{inf,student}.ethz.ch
Attachment:
signature.asc
Description: This is a digitally signed message part.
