El 18/2/2009, a las 14:29, Jay Soffian escribió:
On Wed, Feb 18, 2009 at 8:19 AM, Jay Soffian <jaysoffian@xxxxxxxxx>
wrote:
On Wed, Feb 18, 2009 at 5:06 AM, Wincent Colaiuta <win@xxxxxxxxxxx>
wrote:
Perhaps my eyes are playing tricks on me but I see the original
version
setting MSG to an empty string and exporting it, and your version
setting
MSG to "1" and exporting it. So which one is wrong? The original
or yours?
http://thread.gmane.org/gmane.comp.version-control.git/109897/focus=110462
Rather, http://thread.gmane.org/gmane.comp.version-control.git/109897/focus=110457
(Cursed frame interface.)
(The original is wrong.)
I'm definitely blind then, or perhaps I didn't explain myself. At
least, I saw nothing in the message you linked that answers my
question. Let me try again.
- Prior to your patch, in the two hunks I quoted we set MSG to an
empty string and exported it
- After your patch, the hunks now set MSG to "1" (not the same string)
and export it
In other words, you not only changed the _style_ from "assign and
export in a single step" to "assign and then export as two separate
steps"; you also changed _what_ gets exported in two of those hunks.
So my question really was, was this intended?
Cheers,
Wincent
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
