Brandon Casey <casey@xxxxxxxxxxxxxxx> writes: > Notice the 'export' lines. Comparing it to Thomas's v2 5/5 patch, it > looks like the first line which sets the variables is correct and the > export line should just be 'export MSG GIT_NOTES_REF' in both tests. Thanks for catching my late-night typos. Some shells do not like "export var=val", and the right way to write these is to do an usual assignment and then export just variable names. We need to fix the following: $ git grep -n -e 'export .*=' --and --not -e '-export' pu -- t/ pu:t/t3301-notes.sh:42: export MSG= GIT_NOTES_REF=refs/heads/bogus && pu:t/t3301-notes.sh:48: export MSG= GIT_NOTES_REF=refs/heads/bogus && pu:t/t3302-notes-index-expensive.sh:32: export GIT_INDEX_FILE=.git/temp; pu:t/t3302-notes-index-expensive.sh:66: export GIT_NOTES_REF=non-existing pu:t/t9301-fast-export.sh:188:export GIT_AUTHOR_NAME='A U Thor' pu:t/t9301-fast-export.sh:189:export GIT_COMMITTER_NAME='C O Mitter' pu:t/test-lib.sh:101: export GIT_TEST_LONG=t; shift ;; -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
