On Thu, Feb 5, 2009 at 12:19 AM, Jakub Narebski <jnareb@xxxxxxxxx> wrote: > On Mon, 26 Jan 2009, Giuseppe Bilotta wrote: > >> The RSS 2.0 specification allows an optional managingEditor tag for the >> channel, containing the "email address for person responsible for editorial >> content", which is basically the project owner. > > Hmmm... does it make sense with gitweb? Perhaps it does... I must confess I had my own doubts about this 8-D >> Signed-off-by: Giuseppe Bilotta <giuseppe.bilotta@xxxxxxxxx> >> --- >> gitweb/gitweb.perl | 4 +++- >> 1 files changed, 3 insertions(+), 1 deletions(-) >> >> diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl >> index 3d94f50..cc6d0fb 100755 >> --- a/gitweb/gitweb.perl >> +++ b/gitweb/gitweb.perl >> @@ -6074,7 +6074,9 @@ XML >> print "<title>$title</title>\n" . >> "<link>$alt_url</link>\n" . >> "<description>$descr</description>\n" . >> - "<language>en</language>\n"; >> + "<language>en</language>\n" . >> + # project owner is responsible for 'editorial' content >> + "<managingEditor>$owner</managingEditor>\n"; > > Shouldn't we esc_html($owner), just in case it is for example > "O Wner <owner@xxxxxxxxxxx>" (either via gitweb.owner or via > projects_index being text file listing projects, because I don't > see GECOS having email in it...)? > Indeed, itt's probably safer to do the escaping. -- Giuseppe "Oblomov" Bilotta -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
