On Mon, 26 Jan 2009, Giuseppe Bilotta wrote:
> Add <generator> tag to RSS and Atom feed. Versioning info (gitweb/git
> core versions, separated by a literal slash) is stored in the
> appropriate attribute for the Atom feed, and in the tag content for the
> RSS feed.
Very good idea. I haven't examined either specification, so I don't
know what conventions are used, though... and what conventions _should_
be used.
By the way, gitweb uses in HTML header the following (see
git_header_html subroutine):
<meta name="generator" content="gitweb/$version git/$git_version$mod_perl_version"/>
which tries to follow convention how _web servers_ like Apache return
version information in the 'Server:' HTTP response header (product
tokens). Because it was used on only one place, it was not put into
separate subroutine; should it now?
>
> Signed-off-by: Giuseppe Bilotta <giuseppe.bilotta@xxxxxxxxx>
> ---
> gitweb/gitweb.perl | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
> index f8a5d2e..3d94f50 100755
> --- a/gitweb/gitweb.perl
> +++ b/gitweb/gitweb.perl
> @@ -6085,6 +6085,7 @@ XML
> "<link>$alt_url</link>\n" .
> "</image>\n";
> }
> + print "<generator>gitweb v.$version/$git_version</generator>\n";
> } elsif ($format eq 'atom') {
> print <<XML;
> <feed xmlns="http://www.w3.org/2005/Atom";>
> @@ -6111,6 +6112,7 @@ XML
> } else {
> print "<updated>$latest_date{'iso-8601'}</updated>\n";
> }
> + print "<generator version='$version/$git_version'>gitweb</generator>\n";
I'd rather use '"' for attributes, i.e.
+ print "<generator version=\"$version/$git_version\">gitweb</generator>\n";
> }
>
> # contents
> --
> 1.5.6.5
>
>
--
Jakub Narebski
Poland
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
