On Feb 3, 2009, at 1:19 PM, Johannes Schindelin wrote:
$ git grep -l test_commit junio/next -- t/
junio/next:t/README
junio/next:t/t1450-fsck.sh
junio/next:t/t3410-rebase-preserve-dropped-merges.sh
junio/next:t/t3411-rebase-preserve-around-merges.sh
junio/next:t/t3412-rebase-root.sh
junio/next:t/test-lib.sh
I examined all of those files. I looked at every line that calls
test_commit. All of those files except for t34110-rebase-preserve-
around-merges.sh provide a filename of their own and are therefore
unaffected by the change
On Jan 29, 2009, at 12:19 PM, Junio C Hamano wrote:
- file=${2:-$(echo "$1" | tr 'A-Z' 'a-z')}
+ file=${2:-$(echo "$1" | tr 'A-Z' 'a-z').t}
Use "git grep" without the -l and you will see that all uses outside
of t3411 are of the form "test_commit <commit> <filename>". Only
t3411 uses the form "test_commit <commit>" (without filename), which
is when this change would matter. And t3411 does not use the
generated filename, only the resultant commits.
I was irritated by your statement that I "did not look far" because _I
read all those files_. I gave you the result of reading them which
you seem to have completely ignored, as it was the part of my last e-
mail that you did not quote.
If you want to double-check me, fine. But do not claim I did not do
the work.
~~ Brian
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
