Hi, On Tue, 3 Feb 2009, Brian Gernhardt wrote: > > On Feb 3, 2009, at 11:53 AM, Johannes Schindelin wrote: > > >On Tue, 3 Feb 2009, Brian Gernhardt wrote: > > > > >This change appears to have been forgotten, but does fix the problems > > >I was having. Junio, can this make it into the official repo instead > > >of floating around in my local? I'd send in a patch, but it was your > > >code and I don't want to take credit for it. > > > >Top-poster! > > Well, yes. I wasn't replying to anything in the e-mail, I just wanted to > bring it back to attention. You did, in fact, refer a little bit to the content of the thread you were replying to. > >Besides, I think that my latest comment still stands there: testing is not > >good enough, code inspection is required if something expects the file > >names as they used to be. > > As far as I can tell, no test relies on the auto-generated name of the test > file. In fact, only t3411 uses that feature at all and it only performs > operations on commits. All other uses of test_commit give a filename (even > though many of them don't appear to use the file). You did not look far. Ciao, Dscho -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
