On Wed, Jan 28, 2009 at 08:16:53AM -0800, Shawn O. Pearce wrote: > > But what is more important is that your repository _is_ corrupted, > > Depends. If the SHA-1 came from the remote side during send-pack, Sorry, there is a critical typo in there. I meant to say "_if_ your repository is corrupted" (and I have no idea how I ended up not only omitting a word, but emphasizing the wrong one, so I can only suspect the typo was in my brain and not my fingers). So basically I agree with everything you said. > Yup, I agree. But as you and Junio have already pointed out, C Git > can miss some types of corruption because the revision machinary has > some gaps. *sigh* > > I'd really like to see those gaps closed. But I don't have a good > enough handle on the code structure of the C Git revision machinary > to do that myself in a short period of time. I know JGit's well... > but that's only because I wrote it. ;-) I would like to see them closed, too. But keep in mind that this may actually be a harder form of corruption to achieve than something like just flipping some bits. Once the objects are in a packfile, you are unlikely to lose a single or a small number of objects. But like with any type of corruption, it is infrequent enough that it is hard to say which is more common or "worse". -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
