Jeff King <peff@xxxxxxxx> writes: > But in other cases, it silently gives you the wrong answer. For > example, consider a history like: > > C--D > / > A--B > \ > E--F > > now let's suppose I have everything except 'E'. If I ask for > > git rev-list F..D > > then it will not realize that A and B are uninteresting, and I will get > A-B-C-D. I think it is much better for git to complain loudly that it > could not compute the correct answer. Fair enough. I think we can resurrect the conditional and the traversal option revs->ignore_missing_negative only for this hunk in my [2/2] patch to support that use case. @@ -480,7 +483,7 @@ static int add_parents_to_list(struct rev_info *revs, struct commit *commit, struct commit *p = parent->item; parent = parent->next; if (parse_commit(p) < 0) - return -1; + continue; p->object.flags |= UNINTERESTING; if (p->parents) mark_parents_uninteresting(p); -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
