On Wed, Jan 28, 2009 at 02:43:34AM -0500, Jeff King wrote: > On Wed, Jan 28, 2009 at 02:36:39AM -0500, Jeff King wrote: > > > +#define IS_RUN_COMMAND_ERR(x) (x >= ERR_RUN_COMMAND_FORK) > > <sigh> This should be "<= -ERR_RUN_COMMAND_FORK", since we expect the > negated status. > > Maybe it is time I wrote a test for a failed external. Hmm. Actually, it is hard to write a test case for this; it only triggers if we actually have an error running a program, like fork() failing. -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
