On Tue, Jan 27, 2009 at 05:31:02PM +0100, Johannes Schindelin wrote: > I like the patch series, well designed and concise (especially with the > fixes Hannes proposed). Good. Response seems positive, so I will drop the RFC, then, and post a fixed-up series meant for inclusion. > > There are two potential downsides to the fix: > > > > 1. There is an extra fork and a parent process sitting in memory for > > dashed externals. This is pretty necessary to any fix, since > > something has to wait to do pager cleanup, and we can't rely on the > > child to do so. > > Actually, I think this is a good thing; that way, we can catch > segmentation fault properly and display an error message in the pager. > That was not possible previously. True. On the other hand, most of our externals are shell scripts. It's the builtins that segfault, and we don't have a watcher process for that. :) -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
