On Mon, Jan 26, 2009 at 04:57:16PM -0600, Perry Smith wrote:
> A few other comments: I had to add in the --without-tcltk flag. I
> don't have tcl installed but the config did not autodetect that it was
> not present.
Hmm. It looks like we respect --with[out]-tcltk, and without it we
always say "just use wish from the PATH" without detecting whether it
actually exists:
# No Tcl/Tk switches given. Do not check for Tcl/Tk, use bare
# 'wish'.
TCLTK_PATH=wish
AC_SUBST(TCLTK_PATH)
I'm sure the fix would be something along the lines of
if which wish; then
TCLTK_PATH=wish
else
NO_TCLTK=yes
fi
but I know for fact that is not portable and that there must be some
special autoconf way of doing the same thing.
> I can't tell if make test is happy or not. The output looks like its
> happy but the exit code is 2.
That doesn't sound very happy. You should see either a "command failed"
error from make, or some results like:
'/bin/sh' ./aggregate-results.sh test-results/t*-*
fixed 1
success 4026
failed 0
broken 3
total 4030
where "broken" is OK (it is a test that is marked as "we know this is
broken currently, but ideally it would be fixed in the future") but
"failed" is a problem.
But I believe unless you are using "make -k", that it won't even
aggregate the results if something fails, and you should just see make
complaining about the failed test script.
-Peff
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
