On Tue, 27 Jan 2009, Johannes Schindelin wrote: > > Just that much, most of the backtraces are pretty repetitive. In fact, I > think most if not all of them touch xwrite.c (I got other errors from my > patches, as I expected). > > ==valgrind== Syscall param write(buf) points to uninitialised byte(s) > ==valgrind== at 0x5609E40: __write_nocancel (in /lib/libpthread-2.6.1.so) > ==valgrind== by 0x4D0380: xwrite (wrapper.c:129) > ==valgrind== by 0x4D046E: write_in_full (wrapper.c:159) > ==valgrind== by 0x4C0697: write_buffer (sha1_file.c:2275) > ==valgrind== by 0x4C0B1C: write_loose_object (sha1_file.c:2387) Looks entirely bogus. I suspect that valgrind for some reason doesn't see the writes made by zlib as being initialization, possibly due to some incorrect valgrind annotations on deflate(). We've just totally initialized that whole buffer with deflate(). It definitely does not look like a git bug, but a valgrind run issue. Linus -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
