On Wed, Jan 21, 2009 at 01:56:19PM +0100, Björn Steinbrink wrote: > Another possible solution would be to free the blob data only after the > loop in diffcore_rename has finished, but that's obviously quite bad WRT > memory consumption. :-) Yeah, and it doesn't have the (admittedly smaller, but still there) optimization of not loading the blob data at all if we will never need to. > Anyway, too late, yesterday's attempts 6 to 10 at writing a better > commit message didn't work out either, and Junio has applied the patch > by now. I think that's fine. My message was more about convincing myself that your change was the right thing (and hopefully helped convince others, too). -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
