On 2009.01.20 16:27:23 -0500, Jeff King wrote: > So I think your patch is absolutely the right thing to do. But I think > from the commit message it isn't clear that it would not be equally > correct to follow through on generating cnt_data instead of an early > return (which _isn't_ right, because you might not need to generate > cnt_data at all). Yeah, the commit message wasn't exactly great, but after the fifth attempt I decided to just sent the damn thing, to see whether at least the patch itself makes sense. Another possible solution would be to free the blob data only after the loop in diffcore_rename has finished, but that's obviously quite bad WRT memory consumption. :-) Anyway, too late, yesterday's attempts 6 to 10 at writing a better commit message didn't work out either, and Junio has applied the patch by now. Björn -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
