On Tue, Jan 20, 2009 at 11:36:08AM +0100, Johannes Schindelin wrote: > > > Of course. But the problem is that rev-list is _already_ contaminated > > > by --pretty=format:%Cred. Or do you mean, you really want rev-list to > > > unconditionally output color in such a case? > > > > No, rev-list is not contaminated with UI color options. %Cred _always_ > > outputs the color, even when the user turned off color explicitely, > > using --no-color. > > BTW I would find it very logical for rev-list not to output any color at > all when %C(yellow) is specified, as your code respects the diff UI > options, which are implicitly turned off for rev-list (as rev-list is no > UI), just like the coloring of "commit <name>" is implicitly turned off > for rev-list. Now I'm confused. Should color in --pretty=format always be on, or should it respect color settings? You seem to be advocating both sides in the two paragraphs. The behavior I would propose it along the lines of: - plumbing _always_ has color off - porcelain respects color.* config, --color, etc -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
