Re: [PATCH 2/2] expand --pretty=format color options

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Mon, 19 Jan 2009, Jeff King wrote:

> On Mon, Jan 19, 2009 at 03:10:56PM -0800, Junio C Hamano wrote:
> 
> > > Hrm. OK, it doesn't actually work always. It does for git-log, but 
> > > not for rev-list, which leaves diff_use_color_default as -1. I don't 
> > > know if there are any other ways you can get to this code path 
> > > without having set diff_use_color_default.
> > 
> > Yuck, no matter what you do please don't contaminate plumbing with the 
> > UI color options.
> 
> Of course. But the problem is that rev-list is _already_ contaminated by 
> --pretty=format:%Cred. Or do you mean, you really want rev-list to 
> unconditionally output color in such a case?

No, rev-list is not contaminated with UI color options.  %Cred _always_ 
outputs the color, even when the user turned off color explicitely, using 
--no-color.

Ciao,
Dscho

--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux