Hi, On Sun, 18 Jan 2009, Jeff King wrote: > On Sun, Jan 18, 2009 at 10:41:13AM +0100, Stephan Beyer wrote: > > > > Looks sane except that I do not think you need printf nor the leading > > > blank line, i.e. > > > > > > echo "Patch failed at $msgnum ($FIRSTLINE)" > > > > Hmm, IIRC if $FIRSTLINE contains \n or something like that, it will > > interpret this as newline in some shell/echo implementations. > > > > So printf "...%s..." "$FOO" is always sane for user input. > > Yes, I'm surprised Junio doesn't remember the mass conversions we > already had to do (4b7cc26a and 293623ed). But looking at the date, I > guess it _has_ been a year and a half. :) Hey, be nice to Junio. Have you seen the amount of mails on this list recently? I think Junio's the only one really reading all of them; even if you were right, he would be entitled to a nicer reminder. But you are wrong. And Stephan is wrong, too. The name "FIRSTLINE" suggests that it is indeed a first line, and consequently cannot contain a newline. And indeed, it is defined as FIRSTLINE=$(sed 1q "$dotest/final-commit") Just do the following in any of your favorite shells: $ FIRSTLINE=$(sed 1q README) $ echo "$FIRSTLINE." You'll find that the "." is not in a new line. And I know that we relied on that behavior for an eternity. So there is certainly no need for a printf here. 'nuff said, Dscho -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
