On Mon, Dec 29, 2008 at 10:21 PM, Karl Hasselström <kha@xxxxxxxxxxx> wrote: > On 2008-12-29 21:15:44 +0100, Hannes Eder wrote: > >> What about instead of 'fail with an informative message', just issue >> a warning that the name has been mangled. I use pathnames in patch >> names frequently, so this would be very handy. > > Hmm, I'm still skeptical. Programs that try to be too clever all too > often end up just being annoying and unpredictable. > >> I guess some with with more python skills needs to clean that up, >> this is the first stuff I do in python ;). > > The code looks OK -- but as I said, I don't agree with what it's > trying to do. > > There's a small inconsistency: you fail if the name contains "..", but > correct single bad characters. ".." is used to denote patch name ranges [<patch1>..<patch2>] for commands like "stg pop", "stg push", and so forth, therefore I think it is wise to exclude ".." from single patch names [<patch3>]. > And as I recall, stgit.namelength is about the automatically generated > patch names -- there's no limit for the names provided by the user. Ok. Maybe we should start defining what a 'valid' patch name has to look like, i.e. define def is_patch_name_valid(patchname) Best, Hannes -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
