On 2008-12-29 21:15:44 +0100, Hannes Eder wrote:
> What about instead of 'fail with an informative message', just issue
> a warning that the name has been mangled. I use pathnames in patch
> names frequently, so this would be very handy.
Hmm, I'm still skeptical. Programs that try to be too clever all too
often end up just being annoying and unpredictable.
> I guess some with with more python skills needs to clean that up,
> this is the first stuff I do in python ;).
The code looks OK -- but as I said, I don't agree with what it's
trying to do.
There's a small inconsistency: you fail if the name contains "..", but
correct single bad characters.
And as I recall, stgit.namelength is about the automatically generated
patch names -- there's no limit for the names provided by the user.
--
Karl Hasselström, kha@xxxxxxxxxxx
www.treskal.com/kalle
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
