On Mon, Dec 22, 2008 at 12:07 AM, Shawn O. Pearce <spearce@xxxxxxxxxxx> wrote:
> Felipe Contreras <felipe.contreras@xxxxxxxxx> wrote:
>> + if (!prefixcmp(p, "- ")) {
>> + mode = 0;
>> + p += 2;
>
> This part made me wonder, why are we always doing "S_IFREG | mode"
> further down?
My guess is because 0644 and 0755; doing S_IFREG | mode doesn't
achieve anything for the other modes.
I just sent a patch that I hope makes that more visible.
--
Felipe Contreras
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
