Felipe Contreras <felipe.contreras@xxxxxxxxx> wrote: > + if (!prefixcmp(p, "- ")) { > + mode = 0; > + p += 2; This part made me wonder, why are we always doing "S_IFREG | mode" further down? > + } else { > + p = get_mode(p, &mode); > + if (!p) > + die("Corrupt mode: %s", command_buf.buf); > + switch (mode) { > + case S_IFREG | 0644: > + case S_IFREG | 0755: > + case S_IFLNK: > + case S_IFGITLINK: > + case 0644: > + case 0755: > + /* ok */ > + break; > + default: > + die("Corrupt mode: %s", command_buf.buf); > + } -- Shawn. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html