Matt Kraai <kraai@xxxxxxxxx> writes: > Howdy, > > Wu Fengguang <fengguang.wu <at> intel.com> writes: >> +sub split_addrs { >> + return parse_line('\s*,\s*', 1, @_); >> +} >> + > > I'm not sure it's still a good idea to use parse_line. It should work OK for > now, since split_addrs is only passed one string. If anyone ever tries to pass > it a list of strings, however, parse_line will ignore all but the first. Yikes, I should have caught this. As you point out, this is a breakage waiting to happen until somebody restructures the callers. We should futureproof it by using quotewords() instead. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html