Re: [PATCH 1/8] generate-cmdlist.sh: avoid selecting synopsis at wrong place

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Johannes Schindelin <Johannes.Schindelin@xxxxxx> writes:

> On Sun, 30 Nov 2008, Nguyễn Thái Ngọc Duy wrote:
>
>> In "common" man pages there is luckily no "NAME" anywhere except at 
>> beginning of documents. If there is another "NAME", sed could mis-select 
>> it and lead to common-cmds.h corruption. So better nail it at beginning 
>> of line, which would reduce corruption chance.
>
> I have no idea why you put this into the sparse checkout patch series.

That is because a documentation that triggers the misfortune this patch
fixes is introduced in the series.  I actually scratched head myself,
though, and come to think of it, I should have complained that this patch
should state that because it does not look like it has anything do with
the main topic of the series.

> As it is, the patch series is _already_ hard to review (as it is large not 
> only in term of number of patches, but also individual patch size), 
> _especially_ given the fact that there is no clear, precise and short 
> description of why/how the sparse checkout is implemented.

Hmm, can you really tell the lack of such description without reading the
series, I have to wonder...

--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux