Re: [PATCH 1/8] generate-cmdlist.sh: avoid selecting synopsis at wrong place

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Sun, 30 Nov 2008, Nguyễn Thái Ngọc Duy wrote:

> In "common" man pages there is luckily no "NAME" anywhere except at 
> beginning of documents. If there is another "NAME", sed could mis-select 
> it and lead to common-cmds.h corruption. So better nail it at beginning 
> of line, which would reduce corruption chance.

I have no idea why you put this into the sparse checkout patch series.

As it is, the patch series is _already_ hard to review (as it is large not 
only in term of number of patches, but also individual patch size), 
_especially_ given the fact that there is no clear, precise and short 
description of why/how the sparse checkout is implemented.

For example, instead of using the BLURP area of the cover letter to put 
forth convincing arguments why this is needed, and why it is implemented 
in the best possible manner, you wasted two lines stating the obvious.

IMO that is almost like _asking_ people not to have a look at it.

Ciao,
Dscho

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux