On Fri, Nov 21, 2008 at 13:06, martin f krafft <madduck@xxxxxxxxxx> wrote: > I think you wanted to CC Petr, not Junio. It's also useful to CC > Debian bugs if you know of them. :) I CC'ed Junio, because I think this git rev-parse --git-dir is a bug. For example you can try starting git gui inside a .git dir. > > also sprach Bert Wesarg <bert.wesarg@xxxxxxxxxxxxxx> [2008.11.21.1019 +0100]: >> I really second this. Plus, I think its crucial to check that we are >> not inside the .git directory before setting up topgit. Because git >> rev-parse --git-dir only works in the top .git dir, not deeper (i.e. >> inside .git/refs) and will always return ".". >> >> $(git rev-parse --is-inside-work-tree) || >> die "Not in a git working directory" > > Thanks, noted. I am still working on this patch, since > evaluating $argv/checking for --help at this early stage basically > requires a rewrite of the CLI parsing, ideally using POSIX getopt or > something similar, which takes much of the load away. > > Anyway, Patch for your proposal forthcoming. A patch would depent on your --help patch, Because help should work everywhere. So either I wait for you or do do it. Bert > > -- > .''`. martin f. krafft <madduck@xxxxxxxxxx> > : :' : proud Debian developer, author, administrator, and user > `. `'` http://people.debian.org/~madduck - http://debiansystem.info > `- Debian - when you have better things to do than fixing systems > > (a)bort, (r)etry, (p)retend this never happened > > -----BEGIN PGP SIGNATURE----- > Version: GnuPG v1.4.9 (GNU/Linux) > > iEYEARECAAYFAkkmpDAACgkQIgvIgzMMSnUSKgCghXE+J9KegZ03tetnM3TIcyeM > zn0AoJmYVzh/Kjxk7NFEpQw7USR0daXy > =xl31 > -----END PGP SIGNATURE----- > > -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
