TopGit: ensure worktree (was: [TopGit PATCH] Check for help invocation before setup)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



I think you wanted to CC Petr, not Junio. It's also useful to CC
Debian bugs if you know of them. :)

also sprach Bert Wesarg <bert.wesarg@xxxxxxxxxxxxxx> [2008.11.21.1019 +0100]:
> I really second this. Plus, I think its crucial to check that we are
> not inside the .git directory before setting up topgit. Because git
> rev-parse --git-dir only works in the top .git dir, not deeper (i.e.
> inside .git/refs) and will always return ".".
> 
> 	$(git rev-parse --is-inside-work-tree) ||
> 		die "Not in a git working directory"

Thanks, noted. I am still working on this patch, since
evaluating $argv/checking for --help at this early stage basically
requires a rewrite of the CLI parsing, ideally using POSIX getopt or
something similar, which takes much of the load away.

Anyway, Patch for your proposal forthcoming.

-- 
 .''`.   martin f. krafft <madduck@xxxxxxxxxx>
: :'  :  proud Debian developer, author, administrator, and user
`. `'`   http://people.debian.org/~madduck - http://debiansystem.info
  `-  Debian - when you have better things to do than fixing systems
 
(a)bort, (r)etry, (p)retend this never happened

Attachment: digital_signature_gpg.asc
Description: Digital signature (see http://martin-krafft.net/gpg/)


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux