Johannes Schindelin <Johannes.Schindelin@xxxxxx> writes: > Okay, I understand now, _after_ having looked at the original > levenshtein.c. > > IOW you could have made my task of reviewing your patch much easier. > > Anyway, here is my > > Acked-by: Johannes Schindelin <johannes.schindelin@xxxxxx> > > Thanks for the bugfix, In other words, even the original author's head exploded without looking at extra context lines around the patch. It is a sure sign that the original implementation was too scantily described, and that the fix was not explained well in the proposed commit log message (i.e. in what corner cases the original was bad in what way, and how the patch fixes it). I shouldn't have to decipher the original and the fixed version with pencil and paper when re-reviewing Dscho's Ack. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
