Forgot the sign-off line On Sat, Nov 15, 2008 at 3:26 PM, Giuseppe Bilotta <giuseppe.bilotta@xxxxxxxxx> wrote: > The gitweb_check_feature routine was being used for two different > purposes: retrieving the actual feature value (such as the list of > snapshot formats or the list of additional actions), and to check if a > feature was enabled. > > For the latter use, since all features return an array, it led to either > clumsy code or subtle bugs, with disabled features appearing enabled > because (0) evaluates to 1. > > We fix these bugs, and simplify the code, by separating feature (list) > value retrieval (gitweb_get_feature) from boolean feature check (i.e. > retrieving the first/only item in the feature value list). Usage of > gitweb_check_feature across gitweb is replaced by the appropriate call > wherever needed. Signed-off-by: Giuseppe Bilotta <giuseppe.bilotta@xxxxxxxxx> -- Giuseppe "Oblomov" Bilotta -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
