On Sat, Nov 15, 2008 at 2:15 AM, Junio C Hamano <gitster@xxxxxxxxx> wrote: >> @@ -637,9 +638,9 @@ int cmd_fetch(int argc, const char **argv, const char *prefix) >> remote = remote_get(argv[0]); >> >> transport = transport_get(remote, remote->url[0]); >> - if (verbose >= 2) >> + if (verbosity == VERBOSE) >> transport->verbose = 1; >> - if (quiet) >> + if (verbosity == QUIET) >> transport->verbose = -1; >> if (upload_pack) >> set_option(TRANS_OPT_UPLOADPACK, upload_pack); > > In the original code, the variable verbose can be ">= 2" when "-v -v" is > given, so transport->verbose is not turned on with a single "-v" alone > (this correctly mimics the original behaviour in the scripted version). > Doesn't this also mean that we need to be able to concatenate multiple -v options in git-pull.sh similar to what one of the first versions of my patch did? <snip> -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
