On Mon, 10 Nov 2008 18:51:23 +0100, Miklos Vajna
<vmiklos@xxxxxxxxxxxxxx> wrote:
> On Mon, Nov 10, 2008 at 05:31:01PM +0100, "H.Merijn Brand" <h.m.brand@xxxxxxxxx> wrote:
> > --- Makefile.org 2008-11-10 17:29:53.000000000 +0100
> > +++ Makefile 2008-11-10 17:29:39.000000000 +0100
> > @@ -1329,6 +1329,10 @@ check-sha1:: test-sha1$X
> > ./test-sha1.sh
> >
> > check: common-cmds.h
> > + @`sparse </dev/null 2>/dev/null` || (\
> > + echo "The 'sparse' command is not available, so I cannot make the 'check' target" ;\
> > + echo "Did you mean 'make test' instead?" ;\
> > + exit 1 )
> > for i in *.c; do sparse $(ALL_CFLAGS) $(SPARSE_FLAGS) $$i || exit; done
>
> Please read Documentation/SubmittingPatches, your patch lacks a signoff
> and a commit message.
You're not making things easier for people that do not use git from a
git repo, something that happens quite a lot when you build from a
released tarball.
git-1.6.0.4 $ git format-patch -M
fatal: Not a git repository
Exit 128
I don't like this at all. How much more work is it for you to add the
subject and sign-off yourself, instead of requiring that from people
that like to help?
In the perl development, the only thing we *require* is a diff that
either uses unified (preferred) or context diff.
I did follow the ideal patch flow so far:
--8<---
An ideal patch flow
Here is an ideal patch flow for this project the current maintainer
suggests to the contributors:
(0) You come up with an itch. You code it up.
(1) Send it to the list and cc people who may need to know about
the change.
-->8---
Code speaks louder than words, so I proposed a patch.
This might be my last patch. git is not just another project I want to
loose so much time in.
--8<---
Author: H.Merijn Brand <h.m.brand@xxxxxxxxx>
Date: Mon, 10 Nov 2008 17:31:01 +0100
Make check needs sparse. If sparse is not available, it might as
well be a user error who really wanted make test.
Signed-off-by: H.Merijn Brand <h.m.brand@xxxxxxxxx>
---
diff --git a/Makefile.org b/Makefile
index becd008..718ddf2 100644
--- a/Makefile
+++ b/Makefile
@@ -1329,6 +1329,10 @@ check-sha1:: test-sha1$X
./test-sha1.sh
check: common-cmds.h
+ @`sparse </dev/null 2>/dev/null` || (\
+ echo "The 'sparse' command is not available, so I cannot make the 'check' target" ;\
+ echo "Did you mean 'make test' instead?" ;\
+ exit 1 )
for i in *.c; do sparse $(ALL_CFLAGS) $(SPARSE_FLAGS) $$i || exit; done
remove-dashes:
-->8---
--
H.Merijn Brand Amsterdam Perl Mongers http://amsterdam.pm.org/
using & porting perl 5.6.2, 5.8.x, 5.10.x, 5.11.x on HP-UX 10.20, 11.00,
11.11, 11.23, and 11.31, SuSE 10.1, 10.2, and 10.3, AIX 5.2, and Cygwin.
http://mirrors.develooper.com/hpux/ http://www.test-smoke.org/
http://qa.perl.org http://www.goldmark.org/jeff/stupid-disclaimers/
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
