On Thu, Nov 06, 2008 at 08:15:16AM -0800, Suraj N. Kurapati wrote: > v1 and v2 make the mistake of setting raw mode, which prevent the user from > pressing Control-C to exit the program. v3 fixes this by using cbreak mode. OK, makes sense. > The git-svn.perl script also uses Term::ReadKey. Since it is already in the > git source repository, I thought it was okay to use Term::ReadKey. We are not always consistent with such things, and git-add--interactive is a little "more core" than git-svn, I think. Still, maybe I am being overly cautious. We can always try it and see who complains. ;) I think considering this improvement: > > - This only enhances one particular input, the patch loop. It is > > probably worth being consistent and allowing these behavior for other > > menus (though the numeric inputs are a bit trickier). > > Understood. it makes sense to factor the ReadKey procedure into a separate function anyway. At which point it should be easy enough to substitute in the original behavior if there is no ReadKey. Side note: I don't know if such people exist, but I suppose it is possible that somebody would _prefer_ the old behavior. In which case factoring it out will also make it easier to predicate the behavior on a config variable, if people want that. -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
